Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with older browsers erroring upon setCodecPreferences #418

Merged
merged 2 commits into from
Aug 29, 2022

Conversation

davidzhao
Copy link
Member

On Chrome 96, using setCodecPreferences in the way that we do causes
the browser to fail on setLocalDescription, even for the offer that it
had created.

@cnderrauber With the latest version of the server, can we can fully rely on server-side setCodecPreferences? If so we could deprecate this on the client-side.

On Chrome 96, using setCodecPreferences in the way that we do causes
the browser to fail on setLocalDescription, even for the offer that it
had created.
@changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2022

🦋 Changeset detected

Latest commit: af7fb42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@davidzhao davidzhao linked an issue Aug 28, 2022 that may be closed by this pull request
@cnderrauber
Copy link
Contributor

On Chrome 96, using setCodecPreferences in the way that we do causes the browser to fail on setLocalDescription, even for the offer that it had created.

Failure on the offer it original created even without munged sdp? that's weird.

@cnderrauber With the latest version of the server, can we can fully rely on server-side setCodecPreferences? If so we could deprecate this on the client-side.

We can rely on server-side preference.

@davidzhao
Copy link
Member Author

Failure on the offer it original created even without munged sdp? that's weird.

Yeah it was strange. I disabled munging and it was still failing with the exact same error. The error also cannot be caught.

@davidzhao davidzhao merged commit 82107cf into main Aug 29, 2022
@davidzhao davidzhao deleted the fix-compatibility-browser branch August 29, 2022 16:14
@github-actions github-actions bot mentioned this pull request Aug 29, 2022
max-b pushed a commit to Invisv-Privacy/client-sdk-js that referenced this pull request Oct 4, 2022
…kit#418)

* Fix issue with older browsers erroring upon setCodecPreferences

On Chrome 96, using setCodecPreferences in the way that we do causes
the browser to fail on setLocalDescription, even for the offer that it
had created.

* changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDP error on Samsung Internet 17 & 18
3 participants