Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reconnect timeout handling #321

Merged
merged 4 commits into from
Jul 13, 2022
Merged

Improve reconnect timeout handling #321

merged 4 commits into from
Jul 13, 2022

Conversation

davidzhao
Copy link
Member

Previously multiple attempts could be queued - resulting in more frequent
retries than desired.

Previously multiple attempts could be queued - resulting in more frequent
retries than desired.
@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2022

🦋 Changeset detected

Latest commit: dd2184b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@lukasIO lukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could also change

if (context.retryCount === this._retryDelays.length) return null;

to

if (context.retryCount >= this._retryDelays.length) return null;

just to be safe

@davidzhao davidzhao merged commit 607aa81 into main Jul 13, 2022
@davidzhao davidzhao deleted the fix-reconnect-timeout branch July 13, 2022 21:09
@github-actions github-actions bot mentioned this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants