Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-use external queue lib for signalling queue #301

Merged
merged 4 commits into from
Jul 2, 2022
Merged

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Jul 1, 2022

Instead of having two different queue implementations, this PR gets rid of ours and replaces it with the one used in #300

@changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2022

🦋 Changeset detected

Latest commit: 839c434

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lukasIO lukasIO changed the base branch from main to lukas/queue-parallel-mute July 1, 2022 10:43
@lukasIO lukasIO requested a review from davidzhao July 1, 2022 10:57
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Base automatically changed from lukas/queue-parallel-mute to main July 2, 2022 12:44
@lukasIO lukasIO merged commit a2f36d6 into main Jul 2, 2022
@lukasIO lukasIO deleted the lukas/reuse-queue-lib branch July 2, 2022 13:05
@github-actions github-actions bot mentioned this pull request Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants