Only restart tracks if they are internally managed by the SDK

[lukasIO]

Not very happy about the naming with managed and isTrackManaged because it's quite ambiguous. Could mean both "externally managed" and "internally managed".

[changeset-bot]

🦋 Changeset detected

Latest commit: 83a9c0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
livekit-client	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[davidzhao]

maybe acquiredExternally or userProvidedTrack to indicate a user has acquired the track?

[lukasIO]

@davidzhao one thing where I could argue for both cases is after a call to track.replaceTrack.
Right now calling this function does not mark the track as userProvided but maybe it should.

Reason to argue it should: User is in fact providing a raw MediaStreamTrack. We have no control over it directly. So we should assume it's managed externally.

But: If a user has our APIs previously for creating tracks then it might be that they expect us to manage them also after they called replaceTrack. So maybe the right option is to not change the userProvided state and just default to however the original LocalTrack has been created.

[davidzhao]

@davidzhao one thing where I could argue for both cases is after a call to track.replaceTrack. Right now calling this function does not mark the track as userProvided but maybe it should.

Reason to argue it should: User is in fact providing a raw MediaStreamTrack. We have no control over it directly. So we should assume it's managed externally.

But: If a user has our APIs previously for creating tracks then it might be that they expect us to manage them also after they called replaceTrack. So maybe the right option is to not change the userProvided state and just default to however the original LocalTrack has been created.

Ah good point.. makes sense if they have replaced the Track with something else, then we shouldn't try to reacquire it. I think for users that are doing things that are a bit more advanced, we can let them write a bit more code to handle these corner cases :)