Add fallback to unmunged sdp offer (#386)

* add fallback to unmunged sdp offer * changeset
livekit · Aug 9, 2022 · e64cb2f · e64cb2f
1 parent c11d99d
commit e64cb2f
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/.changeset/spotty-guests-type.md b/.changeset/spotty-guests-type.md
@@ -0,0 +1,5 @@
+---
+'livekit-client': patch
+---
+
+Add fallback to unmunged sdp offer
diff --git a/src/room/PCTransport.ts b/src/room/PCTransport.ts
@@ -134,10 +134,18 @@ export default class PCTransport {
  }
  });
 
- offer.sdp = write(sdpParsed);
  this.trackBitrates = [];
-
- await this.pc.setLocalDescription(offer);
+ const originalSdp = offer.sdp;
+ try {
+ offer.sdp = write(sdpParsed);
+ await this.pc.setLocalDescription(offer);
+ } catch (e: unknown) {
+ log.warn('not able to set desired local description, falling back to unmodified offer', {
+ error: e,
+ });
+ offer.sdp = originalSdp;
+ await this.pc.setLocalDescription(offer);
+ }
  this.onOffer(offer);
  }