-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Executor role implementation. #4737
Conversation
Signed-off-by: aryan <[email protected]>
Signed-off-by: aryan <[email protected]>
Signed-off-by: aryan <[email protected]>
Signed-off-by: aryan <[email protected]>
Converted editor roles to executer role in frontend files. And Changed rbacs of the new Executer role. Signed-off-by: aryan <[email protected]>
Signed-off-by: aryan <[email protected]>
…ers. Signed-off-by: aryan <[email protected]>
Signed-off-by: aryan <[email protected]>
Signed-off-by: aryan <[email protected]>
Signed-off-by: aryan <[email protected]>
* Refactor editor to executer in Authentication service. Signed-off-by: aryan <[email protected]> * Refactor editor to executer in GraphQl servers. Signed-off-by: aryan <[email protected]> * Changing executor roles. Signed-off-by: aryan <[email protected]> * Updation in frontend hooks corresponding to backend refactor. Signed-off-by: aryan <[email protected]> * Executer role implementation. Converted editor roles to executer role in frontend files. And Changed rbacs of the new Executer role. Signed-off-by: aryan <[email protected]> * modification of api specs for executor Signed-off-by: aryan <[email protected]> * removed executor role from userInfraRegistration and fixed import orders. Signed-off-by: aryan <[email protected]> * refactor executer to executor Signed-off-by: aryan <[email protected]> * Removing exector permission from launch experiment FE Signed-off-by: aryan <[email protected]> * minor fix Signed-off-by: aryan <[email protected]> --------- Signed-off-by: aryan <[email protected]> Co-authored-by: Namkyu Park <[email protected]> Signed-off-by: andoriyaprashant <[email protected]>
Hello, all. |
Hey @vitor-campos thanks for the feedback, @Saranya-jena would be able to answer this correctly. Also we most probably would be having the multiple owner feature in the next release. So I think the issue you are facing now would be solved by that. |
Hello, @aryan-bhokare. Thank you for the answer. I have some points to add on top of what you said:
|
Hi @vitor-campos , |
Proposed changes
This pr contains the conversion of
Editor
role to a new roleExecutor
in Litmus.The new
Executor
role can perform following tasks.and all the
Get
,List
tasks.Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.