Added env based support for HTTPS connection #4706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saranya-jena <[email protected]>
Saranya-jena
requested review from
ispeakc0de,
Jonsy13,
gdsoumya,
SarthakJain26 and
namkyu1999
ispeakc0de
reviewed
Jun 14, 2024
| if utils.CustomTlsCert != "" && utils.TlSKey != "" { | ||
| go runGrpcServerWithTLS(applicationService) | ||
| } else { | ||
| log.Fatalf("Failure to start chaoscenter authentication REST server due to empty TLS cert file path and TLS key path") |
There was a problem hiding this comment.
Suggested change
| log.Fatalf("Failure to start chaoscenter authentication REST server due to empty TLS cert file path and TLS key path") | |
| log.Fatalf("Failure to start chaoscenter authentication GRPC server due to empty TLS cert file path and TLS key path") |
ispeakc0de
approved these changes
Jun 14, 2024
Signed-off-by: Saranya-jena <[email protected]>
…tmus into encryption-fixes
SarthakJain26
approved these changes
Jun 21, 2024
Jonsy13
reviewed
Jun 21, 2024
| } | ||
|
|
||
| if enableHTTPSConnection { | ||
| if utils.CustomTlsCert != "" && utils.TlSKey != "" { |
There was a problem hiding this comment.
We can rename it wrt paths
namkyu1999
approved these changes
Jun 24, 2024
Signed-off-by: Saranya-jena <[email protected]>
…tmus into encryption-fixes
Signed-off-by: Saranya-jena <[email protected]>
Jonsy13
reviewed
Jun 24, 2024
| log.Infof("Listening and serving gRPC on %s with TLS", utils.GrpcPort) | ||
| err = grpcServer.Serve(lis) | ||
| if err != nil { | ||
| log.Fatalf("Failure to start litmus-portal authentication GRPC server due to %v", err) |
There was a problem hiding this comment.
Suggested change
| log.Fatalf("Failure to start litmus-portal authentication GRPC server due to %v", err) | |
| log.Fatalf("Failure to start chaos-center authentication GRPC server due to %v", err) |
Jonsy13
reviewed
Jun 24, 2024
| log.Fatalf("Failure to start litmus-portal authentication server due to %s", err) | ||
| } | ||
|
|
||
| // configuration of the certificate what we want |
There was a problem hiding this comment.
Suggested change
| // configuration of the certificate what we want | |
| // configuring TLS config based on provided certificates & keys |
Jonsy13
reviewed
Jun 24, 2024
| @@ -20,6 +21,7 @@ func ValidateRole(ctx context.Context, projectID string, | |||
| requiredRoles, | |||
| invitation) | |||
| if err != nil { | |||
| fmt.Println("errrrrrrrrrrrr ", err) | |||
There was a problem hiding this comment.
This can be removed or print it with logrus and make it error level?
Jonsy13
reviewed
Jun 24, 2024
chaoscenter/graphql/server/server.go
Outdated
| go startGRPCServer(utils.Config.RpcPort, mongodbOperator) // start GRPC serve | ||
| if enableHTTPSConnection { | ||
| if utils.Config.ServerTlsCertPath != "" && utils.Config.ServerTlsKeyPath != "" { | ||
| go startGRPCServerWithTLS("8001", mongodbOperator) // start GRPC serve |
Jonsy13
reviewed
Jun 24, 2024
chaoscenter/graphql/server/server.go
Outdated
| } | ||
| }() | ||
| if enableHTTPSConnection { | ||
| // configuration of the certificate what we want |
There was a problem hiding this comment.
do we need log here as well same as above
log.Infof("graphql server running at https://localhost:%s", utils.Config.HttpsPort)
Signed-off-by: Saranya-jena <[email protected]>
Signed-off-by: Saranya-jena <[email protected]>
Signed-off-by: Saranya-jena <[email protected]>
Signed-off-by: Saranya-jena <[email protected]>
…tmus into encryption-fixes
Signed-off-by: Saranya-jena <[email protected]>
Signed-off-by: Saranya-jena <[email protected]>
Signed-off-by: Saranya-jena <[email protected]>
Signed-off-by: Saranya-jena <[email protected]>
Signed-off-by: Saranya-jena <[email protected]>
…tmus into encryption-fixes
Signed-off-by: Saranya-jena <[email protected]>
Signed-off-by: Saranya-jena <[email protected]>
Signed-off-by: Saranya-jena <[email protected]>
Jonsy13
approved these changes
Jul 8, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Enhanced auth and the graphql server to support both http and https and allow users to leverage either option using env.
Types of changes
What types of changes does your code introduce to Litmus? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: