Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Husky hook fix. #4469

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Conversation

aryan-bhokare
Copy link
Contributor

closes #4468

Proposed changes

Modified pre-commit and pre-push hook scripts to POSIX-compilant.
Now they can run on any environment and most shells like bash, dash, sh, zsh.

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Special notes for your reviewer:

Result of commit after changes.

Screenshot from 2024-02-23 23-38-03

@Saranya-jena
Copy link
Contributor

@aryan-bhokare is it ready for review?

@aryan-bhokare
Copy link
Contributor Author

@aryan-bhokare is it ready for review?

Yes it is. I have tested the changes. I would like someone with mac environment to test it.

@aryan-bhokare aryan-bhokare marked this pull request as ready for review February 29, 2024 13:55
@Saranya-jena Saranya-jena merged commit b85a60d into litmuschaos:master Mar 5, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Husky Hooks not working as expected.
3 participants