Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: revert bump to artifact actions #2910

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Conversation

peterschutt
Copy link
Contributor

The latest changes in these actions have broken the way that we upload coverage reports for later combining, before shipping to sonar.

Additionally, in testing different approaches, I hit actions/download-artifact#249 on multiple occasions - an issue I've never noticed with v3 of these actions.

This PR proposes that we remain on v3 until a good solution can be found for the combined coverage issue, and to give a bit of time for v4 issues to be resolved.

@peterschutt peterschutt requested review from a team as code owners December 15, 2023 11:39
Copy link

sonarcloud bot commented Dec 15, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2910

@peterschutt peterschutt merged commit 3aa93bd into main Dec 15, 2023
16 checks passed
@peterschutt peterschutt deleted the revert-bump-artifact-actions branch December 15, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants