-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: packages tracker ux logic #187
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reviewpad
bot
added
large
Pull request is large
dependencies
Something about our dependencies
enhancement
New feature or request
needs-review
Marks a pull request as waiting for review
labels
Mar 27, 2023
fntlnz
force-pushed
the
better-request-tracking
branch
3 times, most recently
from
March 27, 2023 00:31
4a2a0dd
to
829f7bc
Compare
fntlnz
force-pushed
the
better-request-tracking
branch
from
March 27, 2023 19:52
dd9871c
to
44d58c0
Compare
LGTM |
leodido
requested changes
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for prototyping this @fntlnz!
As discussed privately, we need to revamp this and decide which issue we want to solve. Either:
- giving the CLI a progress indicator
- better handling of the deadline (timeout) errors in the case of "bulk" package requests
Info at #170 (comment)
reviewpad
bot
removed
the
needs-review
Marks a pull request as waiting for review
label
Mar 28, 2023
closing this since this is not the approach we want to take now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
dependencies
Something about our dependencies
enhancement
New feature or request
large
Pull request is large
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #170
How to test this version of the CLI?
To install it:
What happens?
A single request is made for every dependency instead of bulking them
The reason behind this is that by making a single request we can
A progress tracker is shown
Now that one of the benefits of doing a single request is to be able to do fine-grained progress tracking, that's what happens!
Screenshots
here are some screenshots of how it looks like
lstn scan
A request is made for every version mentioned in the
package.json
lstn to react
This is the most basic use case, only the available versions are requested
lstn to react
*`A request is made for every possible version on npm, the progress is shown like this. You will notice that the semver constraint is used to specify what we are processing
lstn in
lstn in
is not included in this. I did the code to actually include it but in is still very unstable for me at the moment until we do #132 . Once this gets merged I'll open an issue to do it.TODO after merge:
lstn in