[uCode] fix uninitialized value in logging of processor index #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This got broken in f8c2609. Before that it would have effectively logged `$processors{$pid}->{processor}`, but the `processor` entry is also the key in `%processors`, i.e. equals `$pid`.
|
See #249 for example output of this bug (not the actual problem in #249, but not helping adding further errors to the log): |
|
Thanks for catching this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got broken in f8c2609.
Before that it would have effectively logged
$processors{$pid}->{processor}, but theprocessorentry is also the key in%processors, i.e. equals$pid.