Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Richtext video embed styling - iframe very small #2344

Closed
hello-kathi opened this issue Sep 21, 2021 · 5 comments
Closed

Richtext video embed styling - iframe very small #2344

hello-kathi opened this issue Sep 21, 2021 · 5 comments
Labels
Dev: Styling issue related to implementation of design

Comments

@hello-kathi
Copy link

URL: OPIN.me
user: Admin
expected behaviour: I insert the youtube link onto the video block or the richtext editor and the video is shown in a proper size
behaviour: Issue warning that the link is invalid
important screensize:
device & browser:
Comment/Question:
There is another behaviour on OPIN dev:
The Video Block is working super fine now, but in the richtext editor the video appears very small, but it is possible to insert the youtube link and save it.

Question: Do we have to fix it on Prod, if the have to do it on Dev and then deploy anyway on prod?

Screenshot
Bildschirmfoto 2021-09-21 um 09 24 23
?

@hello-kathi hello-kathi added the Type: Bug incorrect / uexpected behaviour label Sep 21, 2021
@philli-m philli-m added Dev: Styling issue related to implementation of design and removed Type: Bug incorrect / uexpected behaviour labels Sep 22, 2021
@philli-m
Copy link
Contributor

@hello-kathi So this issue is a little confusing so just to clarify one point about dev, stage and prod:
If you find an issue on prod which is not on dev, that means that hopefully the issue will be resolved in the next release, there is the odd occasion where an issue on prod is a result of the server settings and config and thats why we do stage releases and testing. The stage server is an identicle environment to prod and so stage releases are mostly to check if there are any issues that are caused by having a different server from dev. Hope that helps with prod dev thing?
Ok so I think this issue is actually a styling issue for dev, is that correct? and if so can you add a url?

@hello-kathi
Copy link
Author

@phillimorland That is correct! Ok and sorry for the Confusion!
https://opin-dev.liqd.net/de/best-practices/from-youth-horizont-in-georgia/
On this page if you scroll to the end I put in a rich text block and inserted a video Link and underneath I inserted a video block (that is working fine now!) You will see that the the Youtube Video in the Richtext Block is very small.

@philli-m philli-m changed the title Embette Youtube Videos Richtext video embed styling - iframe very small Sep 22, 2021
@philli-m
Copy link
Contributor

philli-m commented Sep 22, 2021

@hello-kathi cool, thanks for clarification! :)
and one more clarification, as there is a working way to add videos that is correctly styled, this is not a release issue, is that correct?
also as a reference the biggest it could be within a richtext block is as shown below due to the width of the richtext bloc
screenshot(7)
k.

@hello-kathi
Copy link
Author

@phillimorland trick question ;) No, if the Video Block is working after release (and it should because it is working on dev), then we can do this in the next weeks and I can do a workaround with the Video Block.

@hello-kathi
Copy link
Author

@phillimorland and yes the biggest one will do it. But maybe should quickly talk about it. I think it looks weird if the videos have different sizes.

philli-m added a commit that referenced this issue Sep 27, 2021
…pes, update styling, add classname for richtext video, rm title from video block fixes #2344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev: Styling issue related to implementation of design
Projects
None yet
Development

No branches or pull requests

2 participants