fix: refactor dropdown to make it reusable #5675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goapunk
requested changes
Jul 23, 2024
meinberlin/apps/users/templates/meinberlin_users/user_indicator.html
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| openDropdown () { | ||
| this.dropdown.style.display = 'block' |
There was a problem hiding this comment.
I'm fine with this but just wondering if having it in the css is a bit of a clearer division between functionality and styling as we have the is-open class to apply it ?
There was a problem hiding this comment.
good catch, didn´t pay attention as things were kinda recycled. also added BEM for consistency so now its a modifier dropdown--open
There was a problem hiding this comment.
oops i amended with previous commit by mistake
7a7c60b
to
504a29d
Compare
504a29d
to
523f0a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5587, #5596, #5593