Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added dizquetv #749

Closed
wants to merge 3 commits into from
Closed

added dizquetv #749

wants to merge 3 commits into from

Conversation

HWienhold
Copy link

No description provided.

@mvdkleijn
Copy link
Collaborator

Thanks for the contribution. There was a single PHPCS error during the checks. Please correct that issue, otherwise all looking good.

@HWienhold
Copy link
Author

so ideally
Pascal case = class name = namespace = name = the way the app name is actually written ? not sure how that works

@mvdkleijn
Copy link
Collaborator

See one of the other apps (for example adguardhome) in this repo as an example.

@HWienhold
Copy link
Author

Didnt you mean something like phpMyAdmin? bc AdGuard Home is Pascal case. So: shall ich revert to the first commit and add:
// phpcs:ignore then?

@HWienhold HWienhold closed this Jun 22, 2024
@mvdkleijn
Copy link
Collaborator

The app's directory name, classname, etc should all be PascalCase, like for AdguardHome.

But since you closed this PR, the question is no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants