-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closing xed while a large file is loading does not terminate xed #637
Comments
I attempted to verify this issue by opening a 512MB binary file since that is the limit of notepad on windows. I was able to close out of the editor before it finished loading. This may be potentially due to spec differences. Can anyone else verify whether this is a bottleneck of weaker hardware? If so I could look into potentially making a feature like a warning that pops up for larger files/files with long individual lines like some binary file types. |
I see what you mean now. When I tested I used the cancel button first before closing. I feel that is mildly intuitive but it could be a good idea to have the quit functionality just do the cancel under the hood itself and then close out. Is that essentially what you are suggesting? |
I'm suggesting that if the window closes then the program should terminate. Yes, canceling under the hood would achieve that goal. You could also not allow the window to close if the file is still loading and expect the user to press cancel first. Both options would make more sense then the program appearing to close but still running in the background in my opinion. |
I agree. Didn't quite understand your issue at first but this certainly should get fixed. I will look into a solution here soon. Thanks for the extra information! |
new method _xed_tab_cancel_load is called in xed-notebook to prevent use of computer resources after closing xed or a xed tab
Issue
When a large file is loaded a loading bar appears. If xed is closed when the loading bar is still ongoing, xed does not stop running and instead continues to use the CPU.
Steps to reproduce
Expected behaviour
Xed should terminate when it is closed.
Other information
The text was updated successfully, but these errors were encountered: