Fix error when the Content-Length header is missing #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lulol
reviewed
Sep 9, 2022
usr/lib/hypnotix/common.py
Outdated
| @@ -161,7 +161,7 @@ def get_playlist(self, provider, refresh=False) -> bool: | |||
| # Set downloaded size | |||
| downloaded_bytes = 0 | |||
| # Get total playlist byte size | |||
| total_content_size = int(response.headers['content-length']) | |||
| total_content_size = int(response.headers.get('content-length', 0)) | |||
There was a problem hiding this comment.
Have you considered a default of 1 (or 15) instead so at least empty files of failed downloads are not left dangling?
hypnotix/usr/lib/hypnotix/common.py
Lines 179 to 181 in 067e90a
Although they shouldn't hurt since at least these will be silently skipped later.
There was a problem hiding this comment.
I agree. The value 15 seems to be optimal for the prefiltering. Committed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hypnotix raises
KeyErrorwhen a valid playlist response does not haveContent-Lengthheader.I propose to set
total_content_size = 0whenContent-Lengthheader is missing.