Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show feedback in the status bar when search has no results #210

Merged
merged 2 commits into from
May 21, 2022
Merged

Show feedback in the status bar when search has no results #210

merged 2 commits into from
May 21, 2022

Conversation

lulol
Copy link
Contributor

@lulol lulol commented Jan 24, 2022

Channel list still hides when search doesn't return results #194
In this case show some feedback and help in the status bar.

Channel list still hides when search doesn't return results #194
In this case show some feedback and help in the status bar.
@lulol lulol changed the title Show feedback in the status bar when search have no results Show feedback in the status bar when search has no results May 10, 2022
@mtwebster
Copy link
Member

Hi, can you change the status test to simply: 'No channels found'. That's sufficient to let the user know I think. Besides, it can be difficult for translators to work out a complex string like that.

The user can always click the back button to go back to the main page to try again or choose something else - hitting enter on an empty search ideally shouldn't do anything - having a long vertical list of every possible channel isn't all that useful anyhow, but that's another issue.

Thanks

@lulol
Copy link
Contributor Author

lulol commented May 21, 2022

Done.

The default unfiltered list is for the current active group, not of every possible channel.
But that depends of how the playlist is organized.

@mtwebster
Copy link
Member

Ah you're right, if a category is already selected - I was searching from the initial landing page.

@mtwebster mtwebster merged commit 14e2575 into linuxmint:master May 21, 2022
@lulol lulol deleted the feedback-for-search-with-no-results branch May 24, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants