Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround for wayland #105

Closed
wants to merge 2 commits into from
Closed

workaround for wayland #105

wants to merge 2 commits into from

Conversation

spagoc
Copy link

@spagoc spagoc commented Feb 16, 2021

Solves Issue #90. In wayland hypnotix now runs with:
$ GDK_BACKEND=x11 hypnotix

Explanation:
with "$ GDK_BACKEND=x11 hypnotix" hypnotix is forced to run in xwayland but when it launchs mpv this runs in Wayland and you get the error: "AttributeError: ‘GdkWaylandWindow’ object has no attribute ‘get_xid’". With "$ mpv -vo=x11 ..." mpv is forced to run in the x11 environment too.

Issue linuxmint#90
In order to run hypnotix in wayland with:
$ GDK_BACKEND=x11 hypnotix
@mtwebster
Copy link
Member

I'm curious how does mpv normally decide which output driver to use on an x11 backend?

Looking at this:
https://github.com/mpv-player/mpv/blob/master/DOCS/man/vo.rst

they say x11 should not be used ordinarily. So will this option change how mpv behaves in pure x11 sessions? Meaning.. would it auto-select something better (vdpau?)

I just don't want to cause a regression in non-wayland sessions. Would it be better to check for our backend here and only add this if we're forcing x11 compatibility under wayland?

Thanks

@mtwebster mtwebster added the question Further information is requested label Mar 1, 2021
@clefebvre
Copy link
Member

This affects performance.

It's visible during playback and also warned by mpv:

[vo/x11] Warning: this legacy VO has bad performance. Consider fixing your graphics drivers, or not forcing the x11 VO.

Hypnotix also supports MPV options. Go to preferences -> MPV options and add vo=x11. Most people use X11 so the default shouldn't include this option.

@clefebvre clefebvre closed this Apr 15, 2021
@francoism90
Copy link

@clefebvre Most people are now moving to Wayland, is support for this planned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants