Add category hover style for Cinnamenu applet... #11451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and possible future use in the menu applet which currently uses `.menu-category-button-selected` style for hover (pseudo class `hover` is only used when the 'activate categories on click' menu option is set) This also works well as a reasonable fallback style in other light & dark themes as it will add to the style of `.menu-category-button` in themes where `.menu-category-button:hover` is not defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and possible future use in the menu applet which currently only uses
.menu-category-button-selectedstyle for hover. (the pseudo classhoverfor category buttons is only for use when the 'activate categories on click' menu option is set.)This also works well as a reasonable fallback style in all other light & dark themes I have tested as it will add to the style of
.menu-category-buttonin themes where.menu-category-button:hoveris not defined. This fallback style works because.menu-category-button:hoverhas a higher specificity than.menu-category-buttonNote: this change only currently affects Cinnamenu applet. See #10935 (comment) for more details.