cs-info: Add system icon #11090
Merged
cs-info: Add system icon #11090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A vendor can disable this. It simply adds a Gtk Image under the system info data which can be configured by a gschema.
|
The LM logo should be colourful. |
|
The LM logo is not a default preset, i just downloaded it online and set the gschema (which the distro maintainers will set) |
mtwebster
reviewed
Sep 9, 2022
mtwebster
reviewed
Sep 9, 2022
|
|
||
| systemIconPath = getSystemIcon() | ||
| systemIcon = Gtk.Image.new_from_file(systemIconPath) | ||
| page.add(systemIcon) |
There was a problem hiding this comment.
Only add the image if a path is provided, otherwise you end up with:
Only use one gschema for the path. If none is specified, none will be created.
|
gonna have to do some testing when I get home |
If the icon path is left empty, it is actually just "", not None.
|
sorry - it's all good @leigh123linux, @SparkyBluefang and @Fantu - ping to ensure you are aware of the attention needed to the gschema next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A vendor can disable this. It simply adds a Gtk Image under
the system info data which can be configured
by a gschema.
examples:
(Of course, the dimensions would have to be adjusted correctly by the vendor. I just downloaded these online, so like the LM logo would need configuring)