Add function: You can specify sound volume. #3678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
applet.js Add a parameter to spawnCommandLine. settings-schema.json Add scale for specify volume.
|
ping @jake1164 |
|
The last contributions from @jake1164 on his applets seem to be more than 2 years ago. Also I can't remember seeing any reactions to pull requests or issues regarding his applets. So I suggest that we give it another 10 days and if we don't get any reaction we can call his applets abandoned. @kancolle386 would you be interested to be the new maintainer in this case? If not, we just set the author to none. |
|
What happens to this applet when author is set to none? |
|
We won't refer any changes to the author, as there is none. So changes in functionality can be made freely by anyone. Regards Simon |
|
It's been a while now. I'm going to assume applet is abandoned and merge this. Regards Simon |
|
Hello, I would try maintainer of this applet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
applet.js
Add a parameter to spawnCommandLine.
settings-schema.json
Add scale for specify volume.