Display the alarm time in menu and panel #2308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…format can be configured. * Changed the order of the default Preset Times to be strictly in descending order.
|
This looks good, Thanks @sphh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I always wanted to know the time, when the time will finish. I added this with this pull request. It is even possible to format the alarm time. Because some of the alarm times will be in the far future, I believe it's not necessary to show too much detail, hence two time formats can be specified.
I also changed the order of the default Preset Times to be strictly in descending order (the defaults of 2 and 3 hours were in the wrong order).
I still have one question: Is it possible to add a link in the label of a setting? It would be great to point the user to the website with the available format specifiers. At the moment this is included in the tooltip, but that is far from ideal.