lib/digsig: digsig_verify_rsa(): return -EINVAL if modulo length is zero

Currently, if digsig_verify_rsa() detects that the modulo's length is zero, i.e. mlen == 0, it returns -ENOMEM which doesn't really fit here. Make digsig_verify_rsa() return -EINVAL upon mlen == 0. Signed-off-by: Nicolai Stange <[email protected]> Signed-off-by: Herbert Xu <[email protected]>
linux-scraping · May 31, 2016 · c5ce7c6 · c5ce7c6
1 parent 03cdfaa
commit c5ce7c6
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/digsig.c b/lib/digsig.c
@@ -114,13 +114,15 @@ static int digsig_verify_rsa(struct key *key,
  datap += remaining;
  }
 
- err = -ENOMEM;
-
  mblen = mpi_get_nbits(pkey[0]);
  mlen = DIV_ROUND_UP(mblen, 8);
 
- if (mlen == 0)
+ if (mlen == 0) {
+ err = -EINVAL;
  goto err;
+ }
+
+ err = -ENOMEM;
 
  out1 = kzalloc(mlen, GFP_KERNEL);
  if (!out1)