libhns: One optimization and one bugfix #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 20, 2024 14:35
In the srq scenario of cqe inline, the user buffer can be obtained from wqes directly, so actually there is no need to store an additional copy to srq_rinl_buf. Remove this copy can optimize both latency and memory usage. Besides, the release of srq wqes needs to be delayed until the processing of cqe inline payload is finished since the user buffer is obtained from srq wqes now. Fixes: 22cd430 ("libhns: Support cqe inline") Signed-off-by: Junxian Huang <[email protected]>
Add check for input param of hnsdv_query_device() to avoid null ptr. Fixes: cf6d914 ("libhns: Introduce hns direct verbs") Signed-off-by: Junxian Huang <[email protected]>
|
Is there an actual fix in 88d6ac1 ? |
Indeed, it's more of an optimization than a fix. Thanks for pointing it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first patch optimizes cqe inline in srq scenario.
The second one is a bugfix that add checks for input param.