efa: Add unsolicited RDMA write with immediate receive support #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rleon
reviewed
May 8, 2024
| @@ -85,11 +85,17 @@ enum { | |||
| EFA_QP_DRIVER_TYPE_SRD = 0, | |||
| }; | |||
|
|
|||
| enum { | |||
There was a problem hiding this comment.
Please use real SHA and not ?? when creating this patch.
The kernel headers are pushed to wip/leon-for-next
There was a problem hiding this comment.
Thanks, updated the commit.
To commit: 2b8af5001abd ("RDMA/efa: Support QP with unsolicited write w/
imm. receive").
Signed-off-by: Michael Margolin <[email protected]>
Add EFA direct verbs support for creating QPs that do not require explicit receive WRs to accept RDMA write with immediate. Correctly handle completions that didn't consume a WR. Add a related capability bit and update documentation accordingly. Reviewed-by: Daniel Kinsbursky <[email protected]> Reviewed-by: Daniel Kranzdorf <[email protected]> Signed-off-by: Michael Margolin <[email protected]>
Expose EFA direct verbs needed to enable unsolicited RDMA write with immediate receive and to pool for related completions. Reviewed-by: Daniel Kinsbursky <[email protected]> Reviewed-by: Daniel Kranzdorf <[email protected]> Signed-off-by: Michael Margolin <[email protected]>
mrgolin
force-pushed
the
unsolicited-write-recv
branch
from
3f350ce
to
223ddef
Compare
shijin-aws
added a commit
to shijin-aws/libfabric
that referenced
this pull request
May 13, 2024
This patch onboards Libfabric with the rdma-core feature that supports unsolicited RDMA write with immediate receive linux-rdma/rdma-core#1459 . When a rdma-write with imm is unsolicited, libfabric won't release the rx pkt and bump the rx pkt counters. Signed-off-by: Shi Jin <[email protected]>
shijin-aws
added a commit
to shijin-aws/libfabric
that referenced
this pull request
May 13, 2024
This patch onboards Libfabric with the rdma-core feature that supports unsolicited RDMA write with immediate receive linux-rdma/rdma-core#1459 . When a rdma-write with imm is unsolicited, libfabric won't release the rx pkt and bump the rx pkt counters. Signed-off-by: Shi Jin <[email protected]>
shijin-aws
added a commit
to shijin-aws/libfabric
that referenced
this pull request
May 13, 2024
This patch onboards Libfabric with the rdma-core feature that supports unsolicited RDMA write with immediate receive linux-rdma/rdma-core#1459 . When a rdma-write with imm is unsolicited, libfabric won't release the rx pkt and bump the rx pkt counters. Signed-off-by: Shi Jin <[email protected]>
shijin-aws
added a commit
to shijin-aws/libfabric
that referenced
this pull request
May 17, 2024
This patch onboards Libfabric with the rdma-core feature that supports unsolicited RDMA write with immediate receive linux-rdma/rdma-core#1459 . When a rdma-write with imm is unsolicited, libfabric won't release the rx pkt and bump the rx pkt counters. Signed-off-by: Shi Jin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the EFA direct verbs to enable creation of QPs which RQs do not require explicit receive work requests to anticipate incoming RDMA write with immediate. A new work completion query function allows checking whether a work completion is unsolicited.
Related kernel patch: https://lore.kernel.org/all/[email protected]/