Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librdmacm: Misc. fixes #1458

Merged
merged 2 commits into from
May 8, 2024
Merged

librdmacm: Misc. fixes #1458

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a0fc3a
librdmacm: Ack the pending event in sync UD connection
Feb 8, 2024
c4a5ac8
librdmacm: Fix an overflow bug in qsort comparison function
MarkZhang81 Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Next Next commit
librdmacm: Ack the pending event in sync UD connection 
When the server accepts a UD connection request in sync mode,
the event needs to be acked, otherwise destroying the
listening id would get stuck because there is a pending event.
For RC, the event is acked in ucma_complete().

Fixes: 332b203 ("librdmacm: Do not wait in rdma_accept for UD QPs")
Signed-off-by: Oren Sidi <[email protected]>
Reviewed-by: Leon Romanovsky <[email protected]>
Reviewed-by: Sean Hefty <[email protected]>
Signed-off-by: Yishai Hadas <[email protected]>
  • Loading branch information
Oren Sidi authored and Yishai Hadas committed May 5, 2024
commit 9a0fc3afdc9988e4949ee1e2a0fe41058166362a
8 changes: 7 additions & 1 deletion librdmacm/cma.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1951,8 +1951,14 @@ int rdma_accept(struct rdma_cm_id *id, struct rdma_conn_param *conn_param)
return (ret >= 0) ? ERR(ENODATA) : -1;
}

if (ucma_is_ud_qp(id->qp_type))
if (ucma_is_ud_qp(id->qp_type)) {
if (id_priv->sync && id_priv->id.event) {
rdma_ack_cm_event(id_priv->id.event);
id_priv->id.event = NULL;
}

return 0;
}

return ucma_complete(id);
}
Expand Down