libhns: Bugfixes and cleanups #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parse_cqe_for_resp() will never fail and always returns 0. Remove the unused return value. Fixes: 061f7e1 ("libhns: Refactor the poll one interface") Signed-off-by: Junxian Huang <[email protected]>
Fix several context lock issue: 1. db_list_mutex is used without init currently. Add its init to hns_roce_alloc_context(). 2. pthread_mutex_init()/pthread_spin_init() may return error value. Check the return value in hns_roce_alloc_context(). 3. Add destruction for these context locks. 4. Encapsulate init and destruction functions for these context locks. Fixes: 13eae88 ("libhns: Support rq record doorbell") Fixes: 887b78c ("libhns: Add initial main frame") Signed-off-by: Junxian Huang <[email protected]>
The driver should call pthread_spin_destroy() to destroy spin locks before exiting. Signed-off-by: Junxian Huang <[email protected]>
Clear the doorbell when getting it to avoid clearing it in each function that uses hns_roce_alloc_db() Signed-off-by: Chengchang Tang <[email protected]> Signed-off-by: Junxian Huang <[email protected]>
Commit c292b78 ("libhns: Fix the owner bit error of sq in new io") fixed a bug that the SQ head was updated before the owner bit was filled in WQE, but only when using ibv_wr_set_sge(). Actually this bug still exists in other ibv_wr_set_*(). For example, in the flow below, the driver will fill the owner bit in ibv_wr_rdma_write(), but mistakenly overwrite it again in ibv_wr_set_sge_list() or ibv_wr_set_inline_data_list(). ```c ibv_wr_start(); ibv_wr_rdma_write(); if (inline) ibv_wr_set_inline_data_list(); else ibv_wr_set_sge_list(); ibv_wr_complete(); ``` When the SQ wraps around, the overwritten value will be incorrect. Remove all the incorrect owner bit filling in ibv_wr_set_*(). Fixes: 36446a5 ("libhns: Extended QP supports the new post send mechanism") Fixes: c292b78 ("libhns: Fix the owner bit error of sq in new io") Signed-off-by: Chengchang Tang <[email protected]> Signed-off-by: Junxian Huang <[email protected]>
Clean up signed-unsigned mix with relational issue. Fixes: 36446a5 ("libhns: Extended QP supports the new post send mechanism") Signed-off-by: Junxian Huang <[email protected]>
|
Sorry for delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains serveral bugfixes and cleanups.