mlx5: DR, Using sq ts format when RoCE is disabled #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a QP in SW steering, one of the attributes is TS format (timestamp). In some devices, we have a limitation that all QPs should have the same ts_format. The qp_ts_format cap resides under the RoCE caps table, and the cap is not queried when RoCE is disabled. Consider the case when the system is configured to run with REAL_TIME_TS format (0x2), some QPs are created, and we disable RoCE. When trying to construct a new QP, we can't use the qp_ts_format, that is queried from the RoCE caps table. That leads to passing 0x0 (FREE_RUNNING_TS) as the value of the qp_ts_format, which is different than the ts_format of the previous QPs REAL_TIME_TS format (0x2) and the creation will fail. To resolve this, we will read the sq_ts_format, which also reflect the supported ts format for the QP when RoCE is disabled, and override it with qp_ts_format from the RoCE caps table if RoCE is enabled. Fixes: ed504ab ("mlx5: DR, Set QP timestamp mode to default") Signed-off-by: Itamar Gozlan <[email protected]> Signed-off-by: Alex Vesker <[email protected]> Signed-off-by: Yishai Hadas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes an issue in the DR area, to use a proper timestamp format for its internal QP, when RoCE is disabled.
Further details exist as part of the commit log.