bnxt_re/lib: Code refactoring in the resource allocation verbs #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rleon
reviewed
Mar 10, 2024
providers/bnxt_re/main.h
Outdated
| @@ -614,4 +620,14 @@ static inline void bnxt_re_sub_sec_busy_wait(uint32_t nsec) | |||
| } | |||
|
|
|||
| #define BNXT_RE_HW_RETX(a) ((a)->comp_mask & BNXT_RE_COMP_MASK_UCNTX_HW_RETX_ENABLED) | |||
|
|
|||
| static inline uint32_t llog2(uint32_t x) | |||
There was a problem hiding this comment.
we already have this function, "git grep ilog32"
There was a problem hiding this comment.
we already have this function, "git grep ilog32"
Thanks. I missed searching for log32. Will update the PR.
selvintxavier
force-pushed
the
code_refactor
branch
from
6548769
to
749d954
Compare
rleon
reviewed
Mar 11, 2024
providers/bnxt_re/main.h
Outdated
| @@ -554,6 +557,11 @@ static inline void bnxt_re_jqq_mod_last(struct bnxt_re_joint_queue *jqq, | |||
| jqq->last_idx = jqq->swque[idx].next_idx; | |||
| } | |||
|
|
|||
| static inline uint32_t bnxt_re_get_diff(uint64_t cmask) | |||
There was a problem hiding this comment.
There is no value in function which simply returns define
There was a problem hiding this comment.
Agree that it is not useful with the current patch. I will remove it.
I have a follow up series which avoid this diff for newer adapters, that includes kernel driver changes. We will have to check the compatibility mask for adding the diff. I will re-introduce the function for that series.
Adds few helper functions for the series which reorganize the queue memory allocation. Includes functions that allocate/free queue memory and get a buffer address from the allocated memory. Also, added some data structure changes. Signed-off-by: Selvin Xavier <[email protected]>
Refactor the implementation of create_qp for better readability and maintainability. Also, allocate the QP memory and the shadow memory for SQ and RQ together. Split this allocated memory and assign the SQ and RQ virtual address from this memory. Signed-off-by: Selvin Xavier <[email protected]>
Refactor CQ create function for better maintainability. Allocate a memory to hold the queue data structure. Makes corresponding changes where the queue structure is accessed. Signed-off-by: Selvin Xavier <[email protected]>
Code refactoring for better maintainability. Allocate the queue memory and shadow queues together and use the new helper functions to get the address of the queues. Signed-off-by: Selvin Xavier <[email protected]>
Remove the unused functions as the lib has moved to the newer helper functions. Signed-off-by: Selvin Xavier <[email protected]>
selvintxavier
force-pushed
the
code_refactor
branch
from
749d954
to
c6b85f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements few helper functions for better code maintainability. Allocates the queue memory and the shadow queue memory together and manage the pointer for accessing the queue memory and shadow queue memory. Also splits some big functions to smaller sub functions.