bnxt_re/lib: Reduce the Doorbells during SRQ and CQ handling #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently library is ringing Doorbells for every SRQ buffer. Optimize this path and ring DBs only during exit of post send. This is similar to the post_recv implementation. As an exception, ring the DBs before the SRQ arm DBs. Also, bnxt_re_build_srqe always return a possitive value and the return value is not used. So make it a void function. Signed-off-by: Selvin Xavier <[email protected]>
Lib needs to ring CQ doorbell to update the consumer index. Reducing the number of DBs can help in the round trip latency time measured by the benchmark tools. This patch aims to reduce the CQ DBs in the data path. This patch ring the doorbell only once the CQ is half occupied. So for a queue of size n, instead of n doorbells, we will ring only 2 doorbells. This is improving the latency by more than 100ns. To avoid the queue full condition, create the CQs of double the size of what user has requested. Signed-off-by: Selvin Xavier <[email protected]>
|
@selvintxavier when we merge PR, everything that is written there will be visible in commit history, including "Please review and apply Thanks |
Thanks Leon. Will fix it today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some optimizations in data path for Broadcom devices. This series implements some Doorbell moderation techniques to avoid some latency in data path and help to reduce the Doorbell HW FIFO congestion.