rstream [RFC]: Set INLINE data for iWARP #1423
Conversation
|
@tatyana-en , rstream as an example application, why is this change marked as RFC? |
|
It is marked as RFC to get comments, since I didn't discuss it with an rstream maintainer. |
Are you referring to Sean? @shefty |
librdmacm/examples/rstream.c
Outdated
| @@ -304,7 +304,7 @@ static void set_options(int fd) | |||
| rs_setsockopt(fd, SOL_RDMA, RDMA_INLINE, &inline_size, | |||
| sizeof inline_size); | |||
| } else if (optimization == opt_bandwidth) { | |||
| val = 0; | |||
| val = 4; | |||
There was a problem hiding this comment.
I'm soooo out of touch with this code... One could argue the problem is actually in rs_create_ep() and not rstream. The spot in rs_create_ep() where it does this:
if (rs->cm_id->verbs->device->transport_type == IBV_TRANSPORT_IWARP)
rs->opts |= RS_OPT_MSG_SEND;
adjusts the rsocket options, which causes the check below (also in rs_create_ep()) to fail:
if ((rs->opts & RS_OPT_MSG_SEND) && (rs->sq_inline < RS_MSG_SIZE))
return ERR(ENOTSUP);
Technically, there's nothing a use did wrong here. I think a better fix is to handle this internally. Something like:
/* See comment for RS_OPT_MSG_SEND */
if (rs->cm_id->verbs->device->transport_type == IBV_TRANSPORT_IWARP) {
rs->opts |= RS_OPT_MSG_SEND;
if (rs->sq_inline < RS_MSG_SIZE)
rs->sq_inline = RS_MSG_SIZE;
}
There was a problem hiding this comment.
Thanks for the feedback!
Set rsocket SQ INLINE to RS_MSG_SIZE for
iWARP, because rstream sets INLINE to zero
for bandwidth tests and there is a check in
rs_create_ep():
if ((rs->opts & RS_OPT_MSG_SEND) && (rs->sq_inline < RS_MSG_SIZE))
return ERR(ENOTSUP);
which causes the test to fail for iWARP.
Signed-off-by: Tatyana Nikolova <[email protected]>
tatyana-en
force-pushed
the
rstream-iwarp-fix
branch
from
c3d9122
to
fc82b15
Compare
I updated the comment, but you need to go to the commit to see the change. |
|
I meant to the pull request itself. That is, where is says "rstream [RFC]: Set INLINE data for iWARP". It doesn't really matter, since it doesn't end up in the git logs, but can be helpful for whoever is managing the pull requests. |
Unfortunately, I don't know how to do this without closing this PR and opening a new one with a different name. |
Set rsocket SQ INLINE to RS_MSG_SIZE for iWARP.