Add query MR EFA direct verb #1412
Conversation
| }; | ||
| ``` | ||
|
|
||
| *inlen* |
There was a problem hiding this comment.
is inlen part of the struct? Didn't see it
There was a problem hiding this comment.
Nvm it's an argument in efadv_query_mr call.
|
Fixed some Cython 0.26 version specific compilation error and now all tests have passed. |
|
The related kernel patch is here. |
|
Can we have someone review this PR? We have a Libfabric PR pending on this ofiwg/libfabric#9525 |
|
Updated naming for consistency with the kernel patch changes. |
| return err; | ||
| } | ||
|
|
||
| if (ic_id_validity & EFA_QUERY_MR_VALIDITY_RECV_IC_ID) { |
There was a problem hiding this comment.
This ic_id_validity thing doesn't make alot of sense, we already have UVERBS_ATTR_F_VALID_OUTPUT to signal when the attribute was supported. I'd suggest just keeping this simple, make the interconnect ID a u64 and have -1ULL mean not supported, then you can pre-init it to -1 and not worry about this.
There was a problem hiding this comment.
I was looking for some way to get validity of an optional out field after calling to execute_ioctl. Initiating to an illegal value could overcome the need but didn't seem clear enough to me especially there is no logically invalid values for those fields. In addition, it is device sourced validity rather than kernel support / no support.
|
@rleon @jgunthorpe Can you please merge this? We need it in the upcoming release. |
At least you need to update first patch to right kernel commit. Thanks |
To commit: 2307157c8509 ("RDMA/efa: Add EFA query MR support").
Signed-off-by: Michael Margolin <[email protected]>
Add a new EFA DV interface to query for MR attributes. Initial implementation returns interconnects used by the device to reach the MR to write data for receive, RDMA read, and RDMA write receive operations. Update documentation accordingly. Signed-off-by: Michael Margolin <[email protected]>
Expose efadv_query_mr verb and the related types in pyverbs. Signed-off-by: Michael Margolin <[email protected]>
Add basic coverage for EFA direct verbs query MR function. Signed-off-by: Michael Margolin <[email protected]>
|
Updated kernel headers. Thanks. |
This PR is adding a new EFA DV interface to query for MR attributes, with an initial implementation that returns PCIe bus IDs used by the device to reach the MR to write data for receive, RDMA read, and RDMA write receive operations.
Documentation was updated accordingly and pyverbs layer and a test to cover this new functionality are being added.