Bugfixes and improvements for libhns #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To commit: d3f4020a213e ("RDMA/hns: Response dmac to userspace").
Signed-off-by: Junxian Huang <[email protected]>
As dmac is already resolved in kernel while creating AH, there is no need to repeat the resolving in userspace. Prioritize getting dmac from kernel driver, unless kernel driver didn't response one. Signed-off-by: Junxian Huang <[email protected]>
When flushing cqe, the state of qp needs to be modified. The incoming qp attr is not initialized, which may lead to undefined behavior. Fixes: e1726e9 ("libhns: Support flush cqe for hip08 in user space") Signed-off-by: Chengchang Tang <[email protected]> Signed-off-by: Junxian Huang <[email protected]>
The ci/pi of hns roce cq allows data to be flipped. but in __hns_roce_v2_cq_clean(), this flip may lead to an wrong number of loops. This patch fixes it by extending the data type to avoid data flipping. Fixes: 6fe30a1 ("libhns: Introduce QP operations referred to hip08 RoCE device") Signed-off-by: Chengchang Tang <[email protected]> Signed-off-by: Junxian Huang <[email protected]>
Currently the QPC state in HW is modified inside the critical section of spinlock but the ibv_qp state is modified outside. There will be a short period when QPC state has been modified to err with ibv_qp state still remaining RTS. WQEs during this period will still be post-send by RTS-state ibv_qp but then dropped by err-state HW with no flush CQEs generated. To fix this problem, the QPC state in HW and ibv_qp state should be both modified to err inside the critical section of spinlock. Fixes: f1a80cc ("libhns: Bugfix for flush cqe in case multi-process") Signed-off-by: Yangyang Li <[email protected]> Signed-off-by: Junxian Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first 2 patches improve the performance of creating AH, relying on a corresponding kernel patch.
The rest patches are several bugfixes.