tests: Add event-enabled tests over SRD #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdwardSro
suggested changes
Jul 12, 2023
ygoldamzn
force-pushed
the
srd-event-tests
branch
from
65dd62a
to
711737f
Compare
Done.
|
EdwardSro
reviewed
Jul 16, 2023
tests/test_efa_srd.py
Outdated
Comment on lines
30
to
31
| self.server = None | ||
| self.client = None |
There was a problem hiding this comment.
BTW, no need to initiate server and client as it's already done in RDMATestCase.init()
Except for that, it looks good to me.
EdwardSro
approved these changes
Jul 16, 2023
ygoldamzn
force-pushed
the
srd-event-tests
branch
from
711737f
to
dd1332e
Compare
Added event enabled cq tests over SRD, with new and old send. Signed-off-by: Yonatan Goldhirsh <[email protected]>
ygoldamzn
force-pushed
the
srd-event-tests
branch
from
dd1332e
to
3122298
Compare
EdwardSro
approved these changes
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added event enabled cq tests over SRD, with new and old send.