RFC kernel-boot: Update udev rules and rdma_rename to handle auxiliary devices #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y devices Update udev rules for irdma driver to set ID_RDMA_IWARP and ID_RDMA_ROCE environment vars based on the auxiliary device name. For the new rules to work correctly, a patch for the irdma driver is necessary to change the ib device parent from pci to auxiliary device. Change the rdma_rename logic to recognize auxiliary devices and rename ib devices by_onboard or by_pci the same way it did before they were parented by auxiliary devices. Signed-off-by: Tatyana Nikolova <[email protected]>
|
Hi, did you have a chance to review these changes? Do you have any comments? |
|
Thought I commented on the mailing list, send the kernel side as a non-rfc, it looks correct |
|
Thank you, Jason. We are going to send a kernel patch soon and I am going to update this PR to drop the RFC. I was asking to check if you are okay with the user space rdma_rename changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update udev rules for irdma driver to set ID_RDMA_IWARP and ID_RDMA_ROCE environment vars based on the auxiliary device name. For the new rules to work correctly, a patch for the irdma driver is necessary to change the ib device parent from pci to auxiliary device.
Change the rdma_rename logic to recognize auxiliary devices and rename ib devices by_onboard or by_pci the same way it did before they were parented by auxiliary devices.
Signed-off-by: Tatyana Nikolova [email protected]