Add new bitmap API #1144
Merged
Add new bitmap API #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds new bitmap implementation to util directory, which replaces the ccan equivalent, due to the license used (LGPLv2+) which is not fitting in rdma-core. Signed-off-by: Maher Sanalla <[email protected]> Reviewed-by: Avihai Horon <[email protected]> Signed-off-by: Yishai Hadas <[email protected]>
Replace the usage of ccan bitmap with the newly added bitmap implementation in util. As part of it, remove mlx5 bitmap API. Signed-off-by: Maher Sanalla <[email protected]> Reviewed-by: Avihai Horon <[email protected]> Signed-off-by: Yishai Hadas <[email protected]>
Replace the usage of ccan bitmap with the newly added bitmap implementation in util. Signed-off-by: Maher Sanalla <[email protected]> Reviewed-by: Avihai Horon <[email protected]> Signed-off-by: Yishai Hadas <[email protected]>
Replace the usage of ccan bitmap with the newly added bitmap implementation in util. Signed-off-by: Maher Sanalla <[email protected]> Reviewed-by: Avihai Horon <[email protected]> Signed-off-by: Yishai Hadas <[email protected]>
Removes ccan bitmap implementation, along with adjustments to the ccan Makefile. Signed-off-by: Maher Sanalla <[email protected]> Reviewed-by: Avihai Horon <[email protected]> Signed-off-by: Yishai Hadas <[email protected]>
jgunthorpe
reviewed
Feb 28, 2022
| #else | ||
| #define MLX5_SHM_ADDR NULL | ||
| #define MLX5_SHMAT_FLAGS 0 | ||
| #endif |
There was a problem hiding this comment.
This comes from the deleted file providers/mlx5/bitmap.h to control shmat(), it's orthogonal to the bitmap changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series adds new bitmap implementation to util directory which replaces the ccan equivalent.
The ccan/bitmap stuff was published under the LGPLv2+ license which is not fitting in rdma-core.
As of the above, the applicable bitmap code in rdma-core was adapted to use the util new API.