providers/efa: Rename bad op device completion status

Align to device interface on work completion with unsupported operation error. This terminology is more accurate since this error can be related not only to an incorrect opcode. Reviewed-by: Daniel Kranzdorf <[email protected]> Reviewed-by: Youssef Youssef <[email protected]> Signed-off-by: Michael Margolin <[email protected]>
linux-rdma · May 2, 2024 · ff5f993 · ff5f993
1 parent b163249
commit ff5f993
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/providers/efa/efa_io_defs.h b/providers/efa/efa_io_defs.h
@@ -34,8 +34,8 @@ enum efa_io_comp_status {
  EFA_IO_COMP_STATUS_FLUSHED = 1,
  /* Internal QP error */
  EFA_IO_COMP_STATUS_LOCAL_ERROR_QP_INTERNAL_ERROR = 2,
- /* Bad operation type */
- EFA_IO_COMP_STATUS_LOCAL_ERROR_INVALID_OP_TYPE = 3,
+ /* Unsupported operation */
+ EFA_IO_COMP_STATUS_LOCAL_ERROR_UNSUPPORTED_OP = 3,
  /* Bad AH */
  EFA_IO_COMP_STATUS_LOCAL_ERROR_INVALID_AH = 4,
  /* LKEY not registered or does not match IOVA */

diff --git a/providers/efa/verbs.c b/providers/efa/verbs.c
@@ -449,7 +449,7 @@ static enum ibv_wc_status to_ibv_status(enum efa_io_comp_status status)
  case EFA_IO_COMP_STATUS_FLUSHED:
  return IBV_WC_WR_FLUSH_ERR;
  case EFA_IO_COMP_STATUS_LOCAL_ERROR_QP_INTERNAL_ERROR:
- case EFA_IO_COMP_STATUS_LOCAL_ERROR_INVALID_OP_TYPE:
+ case EFA_IO_COMP_STATUS_LOCAL_ERROR_UNSUPPORTED_OP:
  case EFA_IO_COMP_STATUS_LOCAL_ERROR_INVALID_AH:
  return IBV_WC_LOC_QP_OP_ERR;
  case EFA_IO_COMP_STATUS_LOCAL_ERROR_INVALID_LKEY: