providers/efa: Add EFA op_type to post_send trace point

This is essential to distinguish between send, read, and write. Signed-off-by: Yehuda Yitschak <[email protected]> Signed-off-by: Michael Margolin <[email protected]>
linux-rdma · Nov 19, 2023 · 7bde7f5 · 7bde7f5
1 parent c61eb23
commit 7bde7f5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/providers/efa/efa_trace.h b/providers/efa/efa_trace.h
@@ -52,6 +52,7 @@ LTTNG_UST_TRACEPOINT_EVENT(
  LTTNG_UST_TP_ARGS(
  char *, dev_name,
  uint64_t, wr_id,
+ uint8_t, op_type,
  uint32_t, src_qp_num,
  uint32_t, dst_qp_num,
  uint16_t, ah_num
@@ -61,6 +62,7 @@ LTTNG_UST_TRACEPOINT_EVENT(
  LTTNG_UST_TP_FIELDS(
  lttng_ust_field_string(dev_name, dev_name)
  lttng_ust_field_integer(uint64_t, wr_id, wr_id)
+ lttng_ust_field_integer(uint8_t, op_type, op_type)
  lttng_ust_field_integer(uint32_t, src_qp_num, src_qp_num)
  lttng_ust_field_integer(uint32_t, dst_qp_num, dst_qp_num)
  lttng_ust_field_integer(uint16_t, ah_num, ah_num)

diff --git a/providers/efa/verbs.c b/providers/efa/verbs.c
@@ -1863,7 +1863,7 @@ int efa_post_send(struct ibv_qp *ibvqp, struct ibv_send_wr *wr,
  mmio_wc_start();
  }
  rdma_tracepoint(rdma_core_efa, post_send, qp->dev->name, wr->wr_id,
- ibvqp->qp_num, meta_desc->dest_qp_num, ah->efa_ah);
+ EFA_IO_SEND, ibvqp->qp_num, meta_desc->dest_qp_num, ah->efa_ah);
  wr = wr->next;
  }
 
@@ -2144,6 +2144,7 @@ static void efa_send_wr_set_addr(struct ibv_qp_ex *ibvqpx,
  tx_wqe->meta.qkey = remote_qkey;
 
  rdma_tracepoint(rdma_core_efa, post_send, qp->dev->name, ibvqpx->wr_id,
+ EFA_GET(&tx_wqe->meta.ctrl1, EFA_IO_TX_META_DESC_OP_TYPE),
  ibvqpx->qp_base.qp_num, remote_qpn, ah->efa_ah);
 }