Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add highlighting of selected region #88

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

stevanmilic
Copy link
Contributor

@stevanmilic stevanmilic commented Nov 12, 2023

Regression Test

Platforms

  • windows
  • macOS
  • linux

Tasks

  • Use <leader>gl to copy git link.
  • Use <leader>gL to open git link in browser.
  • Copy git link in a symlink directory of git repo.
  • Copy git link in an un-pushed git branch, and receive an expected error.
  • Copy git link in a pushed git branch but edited file, and receive a warning says the git link could be wrong.

@stevanmilic
Copy link
Contributor Author

@linrongbin16 I've ported ruifm/gitlinker.nvim#61. lmk if there's anything else to do

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Files Coverage Δ
lua/gitlinker.lua 59.52% <62.50%> (-7.59%) ⬇️
lua/gitlinker/highlight.lua 13.33% <13.33%> (ø)

... and 3 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

@linrongbin16
Copy link
Owner

i am not in front of my keyboard, will test later

@linrongbin16
Copy link
Owner

linrongbin16 commented Nov 13, 2023

test good, merged into master. hi @stevanmilic , really thanks to your PR!

@linrongbin16 linrongbin16 merged commit 2e97768 into linrongbin16:master Nov 13, 2023
9 of 10 checks passed
This was referenced Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants