refactor: [M3-6901, M3-6909] - Replace Select with Autocomplete in: nodebalancers #10688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lancers Create page
|
Coverage Report: ✅ |
There was a problem hiding this comment.
You have 2 failing E2E tests:
open-support-ticket.spec.ts
This is probably a flake and will pass upon re-runsmoke-create-nodebal.spec.ts
This is likely a real failure caused by differences between Select and Autocomplete. See the test video below:
smoke-create-nodebal.spec.ts.mp4
packages/manager/src/features/NodeBalancers/NodeBalancerActiveCheck.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/NodeBalancers/NodeBalancerConfigPanel.tsx
Outdated
Show resolved
Hide resolved
Yeah, can confirm that this is flake. 😬 I hopefully fixed this in another PR, so disregard any failures on that one here. |
… inline anonymous functions for onChange in AutoComplete : nodebalancers
…t on [Enter] for AutoComplete : nodebalancers
…omplete-in-nodebalancers
hkhalil-akamai
approved these changes
Jul 19, 2024
| inputId={`type-${configIdx}`} | ||
| isClearable={false} | ||
| id={`type-${configIdx}`} | ||
| disableClearable={true} |
There was a problem hiding this comment.
Minor nit:
Suggested change
| disableClearable={true} | |
| disableClearable |
ac64501
to
c17e0b7
Compare
…ble prop in AutoComplete: nodebalancers
bnussman-akamai
approved these changes
Jul 22, 2024
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
We want to get rid of our dependency on react-select for accessibility reasons and to consolidate our usage of third-party libraries.
Changes 🔄
SelectwithAutocompletein theNodeBalancerfeature.Target release date 🗓️
How to test 🧪
Verification steps
(How to verify changes)
Configuration - Port 80box remains unchanged when usingAutocomplete.As an Author I have considered 🤔
Check all that apply