upcoming: [M3-8032] – Add Encrypted/Not Encrypted status to Node Pool table

[dwiley-akamai]

Description 📝

Add encryption status indication to the Node Pool table.

Changes 🔄

• Add 3 new icons to src/assets/icons
• Destructure disk_encryption in NodePoolsDisplay.tsx, pass it down through to NodeTable.tsx
• Update some code patterns in NodePool.tsx

Target release date 🗓️

5/28/24

Preview 📷

Encrypted	Unencrypted

How to test 🧪

The easiest way to test would be to turn on the mocks and navigate to an LKE Details page, since the mocks I added cover the encrypted and unencrypted cases. Otherwise, you'd need your account in alpha to have a "legacy" cluster & pool to see the unencrypted variant.

Verification steps

• Navigate to an LKE Details page with the devtools open. You should observe a GET request to pools?page_size=200
  • See the disk_encryption field for each pool. It should correspond with what's shown in the UI for each.
  • Confirm the Disk Encryption status looks good in mobile view also

As an Author I have considered 🤔

• 👀 Doing a self review
• ❔ Our contribution guidelines
• 🤏 Splitting feature into small PRs
• ➕ Adding a changeset
• 🧪 Providing/Improving test coverage
• 🔐 Removing all sensitive information from the code and PR description
• 🚩 Using a feature flag to protect the release
• 👣 Providing comprehensive reproduction steps
• 📑 Providing or updating our documentation
• 🕛 Scheduling a pair reviewing session
• 📱 Providing mobile support
• ♿ Providing accessibility support

[github-actions]

Coverage Report: ✅
Base Coverage: 81.64%
Current Coverage: 81.64%

[mjac0bs]

With mocks on, I:

• Verified that the node pools with disk_encryption enabled/disabled status displays the expected UI text and icons.
• Verified that encryption status isn't visible if the feature flag is off.

What's the plan for test coverage of LDE changes?

[dwiley-akamai]

What's the plan for test coverage of LDE changes?

The earlier tickets in the epic had mentions of tests but looks like some of the later ones are missing it. I'll go back and update those tickets. In the meantime, I added unit test coverage in the most recent commit

[abailly-akamai]

Confirming display and styling, looks good!

Left comments for code cleanup which should be a very quick fix

[mjac0bs]

Thanks for addressing feedback. I'm approving pending:

• Alban's feedback is addressed
• Tests pass - on this last run, the second runner didn't run at all, probably due to some Jenkins issue because prior to last commit, CI was passing

[abailly-akamai]

Thanks for addressing the changes! approving granted all tests pass 🚢