tracing: just control ansi colors with feature flags #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaghghghgh i want the last two goddamn hours of my life back!!!!!! Signed-off-by: Eliza Weisman <[email protected]>
olix0r
approved these changes
May 13, 2021
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
May 14, 2021
This release adds an `l5d-client-id` header on mutually-authenticated inbound requests so that applications can discover the client's identity. This header is omitted on requests from unauthenticated connections. --- * improve diagnostics for rejected profile discovery (linkerd/linkerd2-proxy#998) * Prepare for Rust 1.50+ by boxing large futures (linkerd/linkerd2-proxy#1003) * http: Remove `identity_from_header` helper (linkerd/linkerd2-proxy#1004) * inbound: Set the l5d-client-id header (linkerd/linkerd2-proxy#981) * chore: update Rust toolchain to 1.52.1 (linkerd/linkerd2-proxy#1005) * tracing: just control ansi colors with feature flags (linkerd/linkerd2-proxy#1006) * ci: Use a matrix of fuzzer targets (linkerd/linkerd2-proxy#1007) * outbound: Box HTTP endpoint stack (linkerd/linkerd2-proxy#1008) * Box all stack modules (linkerd/linkerd2-proxy#1011)
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
May 19, 2021
This release adds an `l5d-client-id` header on mutually-authenticated inbound requests so that applications can discover the client's identity. This header is omitted on requests from unauthenticated connections. --- * improve diagnostics for rejected profile discovery (linkerd/linkerd2-proxy#998) * Prepare for Rust 1.50+ by boxing large futures (linkerd/linkerd2-proxy#1003) * http: Remove `identity_from_header` helper (linkerd/linkerd2-proxy#1004) * inbound: Set the l5d-client-id header (linkerd/linkerd2-proxy#981) * chore: update Rust toolchain to 1.52.1 (linkerd/linkerd2-proxy#1005) * tracing: just control ansi colors with feature flags (linkerd/linkerd2-proxy#1006) * ci: Use a matrix of fuzzer targets (linkerd/linkerd2-proxy#1007) * outbound: Box HTTP endpoint stack (linkerd/linkerd2-proxy#1008) * Box all stack modules (linkerd/linkerd2-proxy#1011)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch changes how ANSI terminal color codes are enabled. Now that
we have updated the proxy to Rust 1.52.1, we can use the
resolver = "2"cargo feature, which results in feature flags enabled by dev
dependencies not enable features in the main build. This lets us
toggle ANSI colors on and off using a dev-dependency, the way you would
expect it to work.
Also, I moved all the test tracing setup into the
linkerd-tracingcrate, so we can use it everywhere.
Closes #997