Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.0-rc2 #1619

Merged
merged 1 commit into from
Aug 31, 2017
Merged

1.2.0-rc2 #1619

merged 1 commit into from
Aug 31, 2017

Conversation

hawkw
Copy link
Member

@hawkw hawkw commented Aug 31, 2017

@hawkw hawkw added this to the 1.2.0 milestone Aug 31, 2017
@hawkw hawkw self-assigned this Aug 31, 2017
@hawkw hawkw requested review from olix0r and adleong August 31, 2017 23:10
Copy link
Member

@klingerf klingerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐️ Works for me.

@hawkw hawkw merged commit 05059b2 into master Aug 31, 2017
Tim-Brooks pushed a commit to Tim-Brooks/linkerd that referenced this pull request Dec 20, 2018
`linkerd inject` was not checking its input for known sidecars and
initContainers.

Modify `linkerd inject` to check for existing sidecars and
initContainers, specifically, Linkerd, Istio, and Contour.

Part of linkerd#1516

Signed-off-by: Andrew Seigner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants