Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc interop: custom_metadata fails #986

Open
stevej opened this issue Jan 25, 2017 · 1 comment
Open

grpc interop: custom_metadata fails #986

stevej opened this issue Jan 25, 2017 · 1 comment

Comments

@stevej
Copy link

stevej commented Jan 25, 2017

/Users/stevej% ./go-grpc-interop-client -use_tls=false  -server_port=60001 -test_case=custom_metadata
2017/01/25 13:34:35 Got the reply with type 0 len 0; want 0, 1

Server output

Jan 25, 2017 1:35:06 PM io.netty.handler.codec.http2.Http2FrameLogger log
INFO:
----------------OUTBOUND--------------------
[id: 0xac92d2f8, L:/127.0.0.1:60001 - R:/127.0.0.1:61505] SETTINGS: ack=false, settings={}
------------------------------------
Jan 25, 2017 1:35:06 PM io.netty.handler.codec.http2.Http2FrameLogger log
INFO:
----------------INBOUND--------------------
[id: 0xac92d2f8, L:/127.0.0.1:60001 - R:/127.0.0.1:61505] SETTINGS: ack=false, settings={}
------------------------------------
Jan 25, 2017 1:35:06 PM io.netty.handler.codec.http2.Http2FrameLogger log
INFO:
----------------OUTBOUND--------------------
[id: 0xac92d2f8, L:/127.0.0.1:60001 - R:/127.0.0.1:61505] SETTINGS: ack=true
------------------------------------
Jan 25, 2017 1:35:06 PM io.netty.handler.codec.http2.Http2FrameLogger log
INFO:
----------------INBOUND--------------------
[id: 0xac92d2f8, L:/127.0.0.1:60001 - R:/127.0.0.1:61505] WINDOW_UPDATE: streamId=0, windowSizeIncrement=983025
------------------------------------
Jan 25, 2017 1:35:06 PM io.netty.handler.codec.http2.Http2FrameLogger log
INFO:
----------------INBOUND--------------------
[id: 0xac92d2f8, L:/127.0.0.1:60001 - R:/127.0.0.1:61505] HEADERS: streamId=1, headers=DefaultHttp2Headers[:method: POST, :scheme: http, :path: /grpc.testing.TestService/UnaryCall, :authority: 127.0.0.1, content-type: application/grpc, user-agent: grpc-go/1.0, te: trailers, x-grpc-test-echo-initial: test_initial_metadata_value, x-grpc-test-echo-trailing-bin: CgsKCwoL], padding=0, endStream=false
------------------------------------
Jan 25, 2017 1:35:06 PM io.netty.handler.codec.http2.Http2FrameLogger log
INFO:
----------------INBOUND--------------------
[id: 0xac92d2f8, L:/127.0.0.1:60001 - R:/127.0.0.1:61505] DATA: streamId=1, padding=0, endStream=true, length=16, bytes=000000000b080010011a050800120100
------------------------------------
Jan 25, 2017 1:35:06 PM io.netty.handler.codec.http2.Http2FrameLogger log
INFO:
----------------OUTBOUND--------------------
[id: 0xac92d2f8, L:/127.0.0.1:60001 - R:/127.0.0.1:61505] HEADERS: streamId=1, headers=DefaultHttp2Headers[:status: 200], streamDependency=0, weight=16, exclusive=false, padding=0, endStream=false
------------------------------------
Jan 25, 2017 1:35:06 PM io.netty.handler.codec.http2.Http2FrameLogger log
INFO:
----------------OUTBOUND--------------------
[id: 0xac92d2f8, L:/127.0.0.1:60001 - R:/127.0.0.1:61505] DATA: streamId=1, padding=0, endStream=false, length=5, bytes=0000000000
------------------------------------
Jan 25, 2017 1:35:06 PM io.netty.handler.codec.http2.Http2FrameLogger log
INFO:
----------------OUTBOUND--------------------
[id: 0xac92d2f8, L:/127.0.0.1:60001 - R:/127.0.0.1:61505] HEADERS: streamId=1, headers=DefaultHttp2Headers[grpc-status: 0], streamDependency=0, weight=16, exclusive=false, padding=0, endStream=true
------------------------------------
Jan 25, 2017 1:35:06 PM io.netty.handler.codec.http2.Http2FrameLogger log
INFO:
----------------INBOUND--------------------
[id: 0xac92d2f8, L:/127.0.0.1:60001 - R:/127.0.0.1:61505] SETTINGS: ack=true
------------------------------------
Jan 25, 2017 1:35:06 PM com.twitter.finagle.buoyant.h2.netty4.Netty4DispatcherBase$$anonfun$loop$lzycompute$1$1 apply
ERROR: [S L:/127.0.0.1:60001 R:/127.0.0.1:61505] dispatcher failed
com.twitter.finagle.ChannelClosedException: ChannelException at remote address: /127.0.0.1:61505. Remote Info: Not Available```
@stevej stevej added the gRPC label Jan 25, 2017
@olix0r
Copy link
Member

olix0r commented Jan 28, 2017

our grpc implementation currently ignores all metadata. We should probably jam this into the context or expose it in interfaces like def call(req: Req, md: Metadata): Future[Rsp]? Or something

Tim-Brooks pushed a commit to Tim-Brooks/linkerd that referenced this issue Dec 20, 2018
This includes the changes that should detect when a client sends a `RST_STREAM`, and cancels our pending response future or streaming body.

Closes linkerd#986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

2 participants