Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store requirejs config in one place. #876

Open
rmars opened this issue Dec 23, 2016 · 0 comments
Open

Store requirejs config in one place. #876

rmars opened this issue Dec 23, 2016 · 0 comments
Labels
dashboard

Comments

@rmars
Copy link
Contributor

rmars commented Dec 23, 2016

Currently we have three require configs in:
linkerd-main.js
namerd-main.js
main-test.js

We should use one of these methods to unify the config.
https://github.com/requirejs/requirejs/wiki/Patterns-for-separating-config-from-the-main-module

Follow up to #873
Tim-Brooks pushed a commit to Tim-Brooks/linkerd that referenced this issue Dec 20, 2018
@siggy
Update Grafana to 5.1.0, handle missing data (linkerd#876)
5a5c6d1 
Conduit 0.4.1 contained some rough edges in the Grafana deployment.

This PR include the following:
- bump Grafana to 5.1.0
- fix deployment and rc graphs when no data present
- fix some text sections overlapping due to scrolling

Fixes linkerd#705

Signed-off-by: Andrew Seigner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dashboard
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmars