Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace namer logging with tracing #84

Open
olix0r opened this issue Feb 9, 2016 · 0 comments
Open

replace namer logging with tracing #84

olix0r opened this issue Feb 9, 2016 · 0 comments
Labels
enhancement

Comments

@olix0r
Copy link
Member

olix0r commented Feb 9, 2016

We have a bunch of debugging logging in our namers. It would be far more useful for this to be replaced by trace annotations (i.e. Trace.record(...)) so that it can be more tightly correlated with requests.

There are some gotchas in here, as we want watch-updates to be separate from tracing in the request path.

This would help in debugging things like #83
@klingerf klingerf removed their assignment Feb 23, 2016
@klingerf klingerf removed the ready label Feb 23, 2016
Tim-Brooks pushed a commit to Tim-Brooks/linkerd that referenced this issue Dec 20, 2018
Bind this.handleApiError in PodDetail (linkerd#84)
4389a1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@klingerf @olix0r