-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
marathon namer: refresh token before expiration #782
Labels
Comments
Tim-Brooks
pushed a commit
to Tim-Brooks/linkerd
that referenced
this issue
Dec 20, 2018
This is a fairly minor refactor to the proxy telemetry tests. b07b554 added a `Fixture` in the Destination service labeling tests added in linkerd#661 to reduce the repetition of copied and pasted code in those tests. I've refactored most of the other telemetry tests to also use the test fixture. Significantly less code is copied and pasted now. Signed-off-by: Eliza Weisman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
currently, the marathon namer waits until it sees an Unauthorized (401) before attempting to refresh it's auth token. it could be a bit smarter by checking the token's expiration, and preemptively refreshing the token.
a couple relevant code snippets:
checking for expiration
better use of types in token encode/decode
motivated by: #759 (comment)
The text was updated successfully, but these errors were encountered: