Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please add Consul Announcer #606

Open
ashald opened this issue Aug 25, 2016 · 4 comments
Open

Please add Consul Announcer #606

ashald opened this issue Aug 25, 2016 · 4 comments
Labels
consul enhancement hacktoberfest help wanted
Projects
Linkerd 1.x Backlog. See https://gith...

Comments

@ashald
Copy link
Member

ashald commented Aug 25, 2016

I believe it could be done in similar way to finagle-consul - by defining a TTL health-check and sending heartbeats every now and then.
@ashald
Copy link
Member Author

ashald commented Aug 25, 2016

I'm a bit busy right now putting linkerd in production but once I'm done with I'd be happy to contribute it if it won't be done by that time.

@olix0r olix0r mentioned this issue Sep 12, 2016
Closed
@ashald
Copy link
Member Author

ashald commented Sep 20, 2016

What kind of health-check do we want use when announcing?

  1. TTL - we will need to configure TTL and send heartbeats
  2. HTTP - Consul is going to make HTTP requests to given endpoint and look for 2XX status codes
  3. TCP - Consul is going to try to connect via TCP to given endpoint periodically

@ashald
Copy link
Member Author

ashald commented Sep 28, 2016

@olix0r do you have an opinion on the question above?

@hawkw hawkw added the consul label Dec 8, 2017
@IssueHuntBot
Copy link

@BoostIO funded this issue with $10. See it on IssueHunt

Tim-Brooks pushed a commit to Tim-Brooks/linkerd that referenced this issue Dec 20, 2018
@franziskagoltz
fix pod status and count in control plane dashboard (linkerd#659)
eff848a 
* fix pod status and count display in control plane dashboard section:
- the control plane would show terminated and stale deployments in the UI, this is confusing and might indicate errors
- this filters out temrinated and failed component deploys from the UI
- it is to note that pending deploys will still be counted and represented with a greyed out status dot
- Fixes: linkerd#606

Signed-off-by: Franziska von der Goltz <[email protected]>


Signed-off-by: Franziska von der Goltz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
consul enhancement hacktoberfest help wanted
Projects
No open projects
Linkerd 1.x Backlog. See https://gith...
Low Priority (small)
Milestone
No milestone
Development

No branches or pull requests
4 participants
@olix0r @ashald @hawkw @IssueHuntBot