Please add announcer support in namerd #605
Labels
Comments
Tim-Brooks
pushed a commit
to Tim-Brooks/linkerd
that referenced
this issue
Dec 20, 2018
The inject code detects the object it is being injected into, and writes self-identifying information into the CONDUIT_PROMETHEUS_LABELS environment variable, so that conduit-proxy may read this information and report it to Prometheus at collection time. This change puts the self-identifying information directly into Kubernetes labels, which Prometheus already collects, removing the need for conduit-proxy to be aware of this information. The resulting label in Prometheus is recorded in the form `k8s_deployment`. Signed-off-by: Andrew Seigner <[email protected]>
Tim-Brooks
pushed a commit
to Tim-Brooks/linkerd
that referenced
this issue
Dec 20, 2018
The Prometheus config in the docker-compose environment had fallen behind the prod setup. This change updates the docker-compose environment in the following ways: - Prometheus config more closely matches prod, based on linkerd#583 - simulate-proxy labels matches prod, based on linkerd#605 - add Grafana container Signed-off-by: Andrew Seigner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It'd be great if namerd could announce its endpoints on its own!
The text was updated successfully, but these errors were encountered: