Report Consul tags in Address.Inet metadata #590
Comments
|
I'd be happy to submit a PR implementing the feature in any form. It'd be great to hear other opinions so we can decide on best approach to handle the problem. |
|
@BoostIO funded this issue with $10. See it on IssueHunt |
Tim-Brooks
pushed a commit
to Tim-Brooks/linkerd
that referenced
this issue
Dec 20, 2018
The existing `conduit dashboard` command supported opening the conduit dashboard, or displaying the conduit dashboard URL, via a `url` boolean flag. Replace the `url` boolean flag with a `show` string flag, with three modes: `conduit dashboard --show conduit`: default, open conduit dashboard `conduit dashboard --show grafana`: open grafana dashboard `conduit dashboard --show url`: display dashboard URLs Part of linkerd#420 Signed-off-by: Andrew Seigner <[email protected]>
|
I think this was fixed in #2297 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In Consul, for each service endpoint arbitrary tags can be applied. Although they're called tags they're more like 'labels' rather than key-value pairs.
The proposal is to report each endpoint's tags within
Address.Inetmetadata as some field (probably,labels) and add support for it in Namer's Thrift IDL.This change probably won't bring any advantages for
linkerdon it's own (at least, I don't see any use-cases for it) but it might be a huge advantage fornamerdtogether with itsresolveendpoint as it can be used to supply some metadata to 3rd party applications using it.The text was updated successfully, but these errors were encountered: